Privacy UI/UX improvements #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks really good. Huge improvement. Only nit I can see from testing: updating the mixed/unmixed account balances when transactions sent across. I have to click to another menu item and back before they update. |
amass01
reviewed
Nov 24, 2020
app/components/modals/MixerSettingsModal/MixerSettingsModal.jsx
Outdated
Show resolved
Hide resolved
|
I would suggest "Allow sending from unmixed account" for the checkbox text instead of the current "Send from unmixed accounts". The existing text reads to me like you're instructing the software to actually "send from unmixed accounts" instead of specifying that the user wants to allow the possibility of doing it. |
vctt94
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2965