Migrate from grpc to grpc-js. #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've converted this to a draft because it should not be merged right now.
|
Epic, thank you! |
|
@matheusd @jholdstock did the needed changes in dcrlnd happen? Was hoping to get this in soon so we could include in the upcoming patch release |
|
Not merged yet decred/dcrlnd#122 |
- Change app dependency from `"grpc"` to `"@grpc-js"`. - Regenerate all proto files with `generate_package_definition` flag. - Remove unused files `annotations_pb.js` and `http_pb.js`, and don't regenerate them `regen.sh`. - In the `regen.sh` for LN protos, use protoc installed locally in node_modules rather than one provided by the system.
|
Rebased and bumped |
|
I hadn't merged the dcrlnd one because we weren't going to merge this for 1.6, but since that's now released I'll merge the dcrlnd change |
|
Ah great thanks. Aiming to add this to the 1.6.1 patch release I think. |
matheusd
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"grpc"to"@grpc-js".generate_package_definitionflag.annotations_pb.jsandhttp_pb.js, and don't regenerate themregen.sh.regen.shfor LN protos, use protoc installed locally in node_modules rather than one provided by the system.Some nice stats...
yarntimeyarn packagetimedecrediton-v1.6.0.tar.gzsize