[governance] "Finished Vote" tab filters #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
reviewed
Nov 10, 2020
There was a problem hiding this comment.
The filters buttons work nicely and solve my issue reported in #2786, but there is an expanse of blank space now (red on screenshot). I think this can be reduced by reducing the height of the buttons and the margin above/below them.
This diff adds the possibility to filter finished voting proposals by its approved or rejected status. Also, this fixes an infinite scroller bug caused by long height screens.
|
lgtm |
victorgcramos
force-pushed
the
2786-proposal-finished-voting-list
branch
from
5015d8e to
10080ac
Compare
amass01
approved these changes
Nov 11, 2020
| @@ -7,6 +7,8 @@ import * as gov from "actions/GovernanceActions"; | |||
| import { usePrevious } from "hooks"; | |||
| import { setLastPoliteiaAccessTime } from "actions/WalletLoaderActions"; | |||
|
|
|||
| const MAX_PAGE_SIZE = 20; // TODO: Get proposallistpagesize from politeia's request: /v1/policy | |||
| @@ -18,7 +20,7 @@ export function useProposalsTab() { | |||
| const [tab, setTab] = useReducer(() => getProposalsTab(location)); | |||
|
|
|||
| useEffect(() => { | |||
| dispatch(setLastPoliteiaAccessTime()); | |||
| return () => dispatch(setLastPoliteiaAccessTime()); | |||
| @@ -157,7 +156,7 @@ const onLoadMoreProposals = async ( | |||
|
|
|||
| const proposalBatch = inventory.slice(proposalLength, proposalNumber); | |||
| try { | |||
| await getProposalsAndUpdateVoteStatus(proposalBatch); | |||
| return await getProposalsAndUpdateVoteStatus(proposalBatch); | |||
There was a problem hiding this comment.
can you please ditch the console.log in the catch block ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds the possibility to filter finished voting proposals by its approved or rejected status.
I think we cannot filter proposals by timestamp, since timestamp filtering is not implemented on politeia, but we can add some filters into the Finished Vote tab, so we could filter props by Approved and Rejected status.
Closes #2786