spv: spv mode indicator on sidebar #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vctt94
reviewed
Sep 14, 2020
|
So I think that we should use the label SPV instead of the icon. What do you think @vctt94? |
|
Hrm I think the icon with a tooltip should suffice for now. We can tweak if people seem to be confused after release. |
|
IMO, on mobile view, adding the spv icon would pollute the current UI. Maybe we should go with the icon + tooltip for the full-width view, and use the label for collapsed views. |
|
Fine by me |
victorgcramos
force-pushed
the
2640-spv-mode-label
branch
2 times, most recently
from
0142f01 to
657c46b
Compare
victorgcramos
force-pushed
the
2640-spv-mode-label
branch
from
657c46b to
66e1760
Compare
|
Collapsed view looks like this: |
alexlyp
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff closes #2640 by adding the SPV icon on "Latest Block" sidebar section.
(on hover)
