GetStartedPages: automated tests #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgptr
force-pushed
the
test-getstarted
branch
3 times, most recently
from
5cd17cd to
e5c65ad
Compare
bgptr
force-pushed
the
test-getstarted
branch
from
8b483d2 to
9ba160e
Compare
bgptr
force-pushed
the
test-getstarted
branch
from
854aa98 to
3ceb685
Compare
bgptr
changed the title
|
Please add closes #2660 to the description. |
bgptr
force-pushed
the
test-getstarted
branch
4 times, most recently
from
72bebcd to
772dacc
Compare
vctt94
reviewed
Oct 21, 2020
There was a problem hiding this comment.
Very good job on this PR!
Having tests will make life much easier for next release, thanks for pushing that forward.
I left some small comments, but I think if you could also add some docs on how to properly make tests that would be great!
Right now I am only running yarn test, is that enough?
app/components/views/GetStartedPage/TutorialPage/TutorialPage.jsx
Outdated
Show resolved
Hide resolved
app/components/views/GetStartedPage/TutorialPage/TutorialPage.jsx
Outdated
Show resolved
Hide resolved
|
Thank you for your review. Running |
bgptr
force-pushed
the
test-getstarted
branch
2 times, most recently
from
26fd508 to
d7632a8
Compare
bgptr
force-pushed
the
test-getstarted
branch
from
d7632a8 to
4d006a3
Compare
bgptr
force-pushed
the
test-getstarted
branch
from
4d006a3 to
5e109b6
Compare
- AdvancedStartupHeader never used - isRemoteValid function call is unnecessary in onSubmitRemoteForm. The submit button is disabled until the form is not valid. - isAppDataValid function call is unnecessary in onSubmitAppDataForm. The submit button is disabled until the form is not valid.
update AnimatedLinearProgressFull test, PrivacyPage test, update walletSelection (ask for passphrase if account discovery is needed) and createWallet test add daemon warning test
- privacy option has removed - add piui checkbox support - specify more Wallet Name label dx
bgptr
force-pushed
the
test-getstarted
branch
from
5e109b6 to
d4d8166
Compare
alexlyp
pushed a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #2606. I focus this time to GetStartedPage components: