Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configured VSP view #2482

Merged
merged 7 commits into from
Jun 15, 2020
Merged

Configured VSP view #2482

merged 7 commits into from
Jun 15, 2020

Conversation

guilhermemntt
Copy link
Contributor

Closes #2305.

vctt94
vctt94 requested changes May 12, 2020
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If clicking to go back, the vsp is removed from decrediton.

We should have a button for it and not be the back button.

image

Also can you remove legacy code from our .less files

@guilhermemntt
Copy link
Contributor Author

guilhermemntt commented May 13, 2020 •
edited
Loading

I removed the legacy .less code that doesn't break other component styles across the ticket views. The "x" button in the specs does intends to remove the configured VSP, but since "x" is commonly used to close current views or return to previous views in Decrediton, we'll wait a decision on what to do in this case.

@vctt94
Copy link
Member

vctt94 commented May 15, 2020

@linnutee will update the issue with the properly icon

vctt94
vctt94 reviewed May 25, 2020
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue was updated with new icons

@guilhermemntt
Copy link
Contributor Author

The remove VSP icon has been updated.

@guilhermemntt guilhermemntt force-pushed the configuredVSPView branch 2 times, most recently from 0af1099 to d4a7023 Compare June 2, 2020 01:31
@guilhermemntt
Copy link
Contributor Author

Rebased.

vctt94
vctt94 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Looks much better with this new icon.

@alexlyp
Copy link
Member

alexlyp commented Jun 9, 2020

Needs a rebase.

@guilhermemntt
Copy link
Contributor Author

Rebased.

@alexlyp alexlyp merged commit e073125 into decred:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vctt94 vctt94 vctt94 approved these changes

@alexlyp alexlyp alexlyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual Design: Configured VSPs view
3 participants
@guilhermemntt @vctt94 @alexlyp