Functional proposal details #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vctt94
force-pushed
the
functoinal-proposal-details
branch
2 times, most recently
from
fdd13d4 to
d4c590b
Compare
vctt94
force-pushed
the
functoinal-proposal-details
branch
from
d4c590b to
3538fa6
Compare
amass01
reviewed
Apr 6, 2020
| } | ||
| } | ||
|
|
||
| function ChooseVoteOption({ |
There was a problem hiding this comment.
Suggested change
| function ChooseVoteOption({ | |
| const ChooseVoteOption = ({...}) => |
There was a problem hiding this comment.
Here, as it is a component, I'd rather let it as function. Otherwise, as an arrow function it does not show at the stack trace, when erroring, which makes debug harder.
amass01
approved these changes
Apr 9, 2020
| eligibleTicketCount,currentVoteChoice, showPurchaseTicketsPage | ||
| }) => { | ||
| // getVoteInfo is an auxiliar function to get the properly vote info component. | ||
| function getVoteInfo () { |
| /> | ||
| );} | ||
|
|
||
| function getError(error) { |
vctt94
force-pushed
the
functoinal-proposal-details
branch
from
54407c5 to
0d921f2
Compare
|
Changed. Thanks for reviewing |
vctt94
force-pushed
the
functoinal-proposal-details
branch
from
0d921f2 to
1c35c99
Compare
alexlyp
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #2448.
It makes proposal details a functional component. With that we can remove our
proposalconnectors