[win32] Explicitly close rx pipe when closing wallet #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
win-close-pipe
branch
from
a74c88b to
5d098f5
Compare
jrick
reviewed
Oct 1, 2018
app/modules/win32ipc/pipe_wrapper.cc
Outdated
| @@ -48,5 +48,18 @@ result<pipe> create_pipe(pipe_direction direction) { | |||
| err: | |||
| return result<pipe>::error(err_msg); | |||
| } | |||
|
|
|||
|
|
|||
| result<int> close_pipe_end(uintptr_t read_end_handle, uintptr_t write_end_handle) { | |||
There was a problem hiding this comment.
this return value doesn't agree with the header declaration
|
@jrick Updated the module so that See if you prefer this version. |
matheusd
force-pushed
the
win-close-pipe
branch
from
f2001af to
7f61105
Compare
6 tasks
alexlyp
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1675
Close #1653
Fix #1645