spv: Teardown syncer after all peers are lost #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2025
JoeGruffins
approved these changes
Jan 28, 2025
|
Try #2466 for the spinning reconnect issue |
During clean shutdown, signal the mixing client to shutdown first, waiting for it to finish running, before closing the RPC and SPV syncers. Updates the mixing module to a version that supports continuing active mixes before terminating the mixing client.
Recreate a new syncer in the SPV reconnect loop in main. This will allow initial sync logic to be reperformed if peers can be connected later. This also adds a forced 5s backoff before peers connection attempts are made again, matching the backoff behavior for RPC syncing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate a new syncer in the SPV reconnect loop in main. This will allow
initial sync logic to be reperformed if peers can be connected later.
This also adds a forced 5s backoff before peers connection attempts are made
again, matching the backoff behavior for RPC syncing.
Rebased over #2463.