rpc: Add SetVspdVoteChoice request #1981
Merged
+1,089
−757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
force-pushed
the
ayp_update_vote_vspd
branch
from
7bf807c to
60acf13
Compare
jrick
requested changes
Feb 18, 2021
internal/vsp/feepayment.go
Outdated
Comment on lines
641
to
647
| if len(ticketTx.TxOut) != 3 { | ||
| return fmt.Errorf("ticket %v has multiple commitments: %w", ticketHash, errNotSolo) | ||
| } | ||
|
|
||
| if !stake.IsSStx(ticketTx) { | ||
| return fmt.Errorf("%v is not a ticket", ticketHash) | ||
| } |
There was a problem hiding this comment.
let's reverse these two checks, so if it does not have 3 outputs and is not a ticket, we don't report it as one.
internal/vsp/vsp.go
Outdated
| @@ -241,3 +241,38 @@ func (c *Client) ProcessWithPolicy(ctx context.Context, ticketHash *chainhash.Ha | |||
| } | |||
| return fp.submitPayment() | |||
| } | |||
|
|
|||
| // SetVoteChoice takes all | |||
internal/vsp/vsp.go
Outdated
Comment on lines
247
to
253
| c.mu.Lock() | ||
| _, ok := c.jobs[*hash] | ||
| c.mu.Unlock() | ||
| if ok { | ||
| // Already processing this ticket with the VSP. | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This will prevent us from setting vote choices for any ticket being processed. I believe you meant to test for !ok.
internal/vsp/feepayment.go
Outdated
| @@ -630,6 +630,66 @@ func (c *Client) status(ctx context.Context, ticketHash *chainhash.Hash) (*ticke | |||
| return &resp, nil | |||
| } | |||
|
|
|||
| func (c *Client) setVoteStatus(ctx context.Context, ticketHash *chainhash.Hash, choices []wallet.AgendaChoice) error { | |||
jrick
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command connects with the provided VSP host/pubkey and updates any ticket voting choice that VSP may control for the wallet.