Handle VSP ticket status "received". #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "received" status is expected during normal operation. The wallet should not just log a warning, it should handled this status the same was as the "broadcast" status - continue waiting for the status to update to "confirmed". Without this handling, the wallet never notices that the fee has been confirmed and never removes the ticket from the VSP client.
jholdstock
force-pushed
the
receive-warn
branch
from
25bd08c to
b83029e
Compare
dajohi
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "received" status is expected during normal operation. The wallet should not just log a warning, it should handle this status the same was as the "broadcast" status - continue waiting for the status to update to "confirmed".