Avoid uncommon CoinJoin output amounts #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Jun 9, 2020
When large UTXOs are mixed, the mixed output amount was chosen as the smallest preprogramed amount which would result in one or more mixed outputs. This had the unfortunate side effect of advertising seldom used mixed output amounts to a CoinShuffle++ server which were uncommon relative to amounts advertised by clients participating in mixed ticket buying. As a workaround, the current sdiff is queried, and a decision is made whether to use an even smaller mixed amount which will allow for better pairings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When large UTXOs are mixed, the mixed output amount was chosen as the
smallest preprogramed amount which would result in one or more mixed
outputs. This had the unfortunate side effect of advertising seldom
used mixed output amounts to a CoinShuffle++ server which were
uncommon relative to amounts advertised by clients participating in
mixed ticket buying.
As a workaround, the current sdiff is queried, and a decision is made
whether to use an even smaller mixed amount which will allow for
better pairings.