Introduce addtransaction JSON-RPC, remove unnecessary others #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Apr 24, 2020
This adds a new JSON-RPC method to manually add a transaction to the wallet and record it mined in a block. This is particularly useful for the upcoming VSP design which will require spending transaction outputs from transactions which have already been mined by the time a private key was imported. Though it is possible to record these transaction using a rescan, this is more work for voting wallets which should avoid long database updates as much as possible. The addticket and stakepooluserinfo RPCs are removed in this change. addticket usage can be replaced with addtransaction. stakepooluserinfo is no longer used by stakepoold to decide what tickets shall be voted for, and is therefore no longer needed. Any remaining use of stakepooluserinfo by dcrstakepool should be replaced by stakepoold itself providing the hashes of tickets it will vote with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new JSON-RPC method to manually add a transaction to the
wallet and record it mined in a block. This is particularly useful
for the upcoming VSP design which will require spending transaction
outputs from transactions which have already been mined by the time a
private key was imported. Though it is possible to record these
transaction using a rescan, this is more work for voting wallets which
should avoid long database updates as much as possible.
The addticket and stakepooluserinfo RPCs are removed in this change.
addticket usage can be replaced with addtransaction.
stakepooluserinfo is no longer used by stakepoold to decide what
tickets shall be voted for, and is therefore no longer needed. Any
remaining use of stakepooluserinfo by dcrstakepool should be replaced
by stakepoold itself providing the hashes of tickets it will vote
with.