Introduce an errors package #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change supports extracting database code into a database package. Both the pool package and database package would be dependent on errors.go, and so a circular dependency would be introduced unless an errors package is introduced.
dnldd
reviewed
Nov 5, 2020
pool/boltupgrades.go
Outdated
| // understood by the program. Databases with recorded versions higher than | ||
| // this will fail to open (meaning any upgrades prevent reverting to older | ||
| // software). | ||
| LatestBoltDBVersion = paymentUUIDVersion |
There was a problem hiding this comment.
This should probably just be BoltDBVersion.
dnldd
reviewed
Nov 5, 2020
errors/error.go
Outdated
Comment on lines
165
to
175
| // Is returns whether err equals or wraps target. | ||
| func Is(err, target error) bool { | ||
| return errors.Is(err, target) | ||
| } | ||
|
|
||
| // As attempts to assign the error pointed to by target with the first error in | ||
| // err's error chain with a compatible type. Returns true if target is | ||
| // assigned. | ||
| func As(err error, target interface{}) bool { | ||
| return errors.As(err, target) | ||
| } |
There was a problem hiding this comment.
Hmm, looking at the call sites for these i think a namespace alias is a better fit than these funcs.
dnldd
reviewed
Nov 5, 2020
pool/paymentmgr.go
Outdated
| @@ -29,7 +30,7 @@ const ( | |||
|
|
|||
| // maxRoundingDiff is the maximum amount of atoms the total | |||
| // output value of a transaction is allowed to be short of the | |||
| // provided input due to rounding errors. | |||
| // provided input due to rounding e. | |||
dnldd
reviewed
Nov 5, 2020
pool/paymentmgr.go
Outdated
| @@ -607,20 +608,20 @@ func (pm *PaymentMgr) generatePayoutTxDetails(ctx context.Context, txC TxCreator | |||
|
|
|||
| // Ensure the transaction outputs do not source more value than possible | |||
| // from the provided inputs and also are consuming all of the input | |||
| // value after rounding errors. | |||
| // value after rounding e. | |||
dnldd
reviewed
Nov 5, 2020
pool/paymentmgr_test.go
Outdated
| cancel() | ||
| t.Fatalf("expected an input output mismatch error") | ||
| } | ||
|
|
||
| // Ensure generating payout tx details returns an error if the outputs of | ||
| // the transaction do not exhaust all remaining input value after rounding | ||
| // errors. | ||
| // e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports extracting database code into a database package. Both the pool package and database package would be dependent on errors.go, and so a circular dependency would be introduced unless an errors package is introduced.