-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec/api: Document client RPC server http methods. #702
Conversation
We actually don't specify client implementation, but this is all good info. Let's make it a wiki page or the readme for the client/rpcserver package. |
f8b5001
to
44703eb
Compare
@buck54321 Where should I put it exactly? In spec folder? Thanks for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This will be very helpful. I think we can add it to dex's docs folder.
One good example of docs is the one from dcrd: https://github.com/decred/dcrd/tree/master/docs
but anyway, I think that's a good start
So if you make it a readme for rpcserver, you'd put it at client/rpcserver/README.mediawiki. To make it a wiki page, see https://github.com/decred/dcrdex/wiki. The specification document just doesn't describe the client. Or the server, for that matter. Just the API and protocols. |
44703eb
to
371356f
Compare
Moved to the wiki. Not sure at all to pr this. Changes can be seen here: This is the diff: diff
|
5417c41
to
92505fa
Compare
Sorry for the delay. Can you nuke the go.{mod,sum} files? We just have the one module for now. I'll get your wiki diff committed to dcrdex.wiki master. |
Add docs/examples and an example for setting up a client rpcserver client.
92505fa
to
99e2223
Compare
Thanks. The wiki is updated BTW. I made some edits to clarify the page a bit. |
@vctt94 for one was asking how to communicate with core using Decrediton. Hopefully this opens up the rpcserver to be used by consumers other than dexcctl.
While writing this out I noticed a few things I would like input on.