auth,dex,dcrdex: anarchy setting #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
reviewed
Apr 15, 2020
On Penalize, the connection should stay open to handle active swaps, and active orders if we allow that. On failed Send or Request/RequestWithTimeout, call removeClient.
chappjc
commented
Apr 15, 2020
| auth.storage.CloseAccount(client.acct.ID, rule) | ||
| client.conn.Banish() // May not want to do this. Leaving it for now. | ||
| auth.removeClient(client) |
There was a problem hiding this comment.
I noticed that this was the only removeClient, so on failed Send and Requests, I now call removeClient. However, we may wish to add the On method to the Link interface so that it is ultimately up to the WSLink if the connection is really dead. On the other hand, auth'd clients could stay in the AuthManager's clients map forever, but I don't like having it grow without bounds.
buck54321
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably temporary, but it helps a lot in testing.