Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Move sign out menu item to bottom of hamburger menu #2590

Merged
merged 2 commits into from
Nov 9, 2023
Merged

ui: Move sign out menu item to bottom of hamburger menu #2590

merged 2 commits into from
Nov 9, 2023

Conversation

peterzen
Copy link
Member

@peterzen peterzen commented Nov 2, 2023 •
edited
Loading

Sign out is usually at the bottom of profile menus.

image

buck54321
buck54321 reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

The <hr> element is showing even when the profileSignout element is not.

image

Otherwise, ready.

@peterzen
Copy link
Member Author

peterzen commented Nov 9, 2023

Good call.

The <hr> element is showing even when the profileSignout element is not.

image

Otherwise, ready.

Removed the separator altogether, it didn't look quite right on a second look.

@buck54321 buck54321 merged commit 1f1068a into decred:master Nov 9, 2023
5 checks passed
@peterzen peterzen deleted the profile-menu-signout branch November 9, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterzen @buck54321