UI: update tab/window title when user changes market and fix minor display issues on market page #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
reviewed
Aug 4, 2023
The title is updated in |
martonp
approved these changes
Aug 4, 2023
JoeGruffins
approved these changes
Aug 5, 2023
buck54321
requested changes
Aug 17, 2023
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
This includes: - Display balance widget when balance note is received only if the asset is set in the balance widget. - Ensure there are visible changes when user clicks on another market instead of waiting for order book note which might delay. These visible changes include: clearing the depth chart, order book and recent matches, setting the balance widget wallets, selecting and saving the market. - Setting a bottom border for the "Create wallets to trade" message. Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
force-pushed
the
mkt-page-tab
branch
from
f89367a to
3b1527e
Compare
|
Thanks for the review @buck54321. Let me know when you want me to squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2115 and resolves some improvements detailed in f89367a commit message.
Notable UI changes:
Before now, the "Create Wallets to trade" message had no bottom border to separate it from the other details in that section.
The changes in this PR ensure improved UX - the user will notice more visual changes on the markets page when they select a new market
beforethe order book note is received.