client/core: enable reconfiguration restrictions / extension mode #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
martonp
approved these changes
Aug 4, 2023
client/core/types.go
Outdated
| // should not be displayed to the user. | ||
| HiddenFields []string `json:"hiddenFields"` | ||
| // DisableWalletType indicates that we should not offer the user an | ||
| // an option to chznge the wallet type. |
JoeGruffins
approved these changes
Aug 5, 2023
buck54321
force-pushed
the
extension-mode
branch
from
baa08e1 to
ccd6aae
Compare
Whoops. I meant to respond to this. From what I can tell, yes, Decrediton starts dcrwallet with the rpc server and then points dexc at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an option to restrict GUI wallet reconfiguration options for wallets that are controlled by the caller, e.g. Decrediton. This prevents users from accidentally changing the wallet type, password, or specific configuration fields.