Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/market: dont call RecordCancel under the bookMtx #2449

Merged
merged 2 commits into from
Aug 9, 2023
Merged

server/market: dont call RecordCancel under the bookMtx #2449

merged 2 commits into from
Aug 9, 2023

Conversation

buck54321
Copy link
Member

No description provided.

JoeGruffins
JoeGruffins approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks to solve the problem with no side effects.

@JoeGruffins
Copy link
Member

Sorry, I spoke too soon. Seeing some strangeness still. Some ghost orders?
image

@buck54321 buck54321 requested a review from chappjc August 9, 2023 04:37
@buck54321 buck54321 mentioned this pull request Aug 9, 2023
Merged
JoeGruffins
JoeGruffins approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last change looks to have solved the issue I was seeing.

@buck54321 buck54321 removed the request for review from chappjc August 9, 2023 07:10
@buck54321 buck54321 merged commit dc7af08 into decred:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buck54321 @JoeGruffins