Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: Fix order marker bug #2448

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

ukane-philemon
Copy link
Contributor

Closes #2373

    - MetaOrder.status was not set but was used in other parts of the code,
      This oversight prevented markers from being set the first time
      an order changes it's status to Booked.

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the status fix resolved the issue, but the AsyncOrderSubmitted change seems right.

@buck54321 buck54321 merged commit 4ab15ac into decred:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: depth chart marker for own orders reluctantly appears
2 participants