server/asset/btc: compile time configurable poll interval #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
May 4, 2023
There was a problem hiding this comment.
Working as intended, but why a compile time setting rather than a config setting? I think the locktimes are compile time because they should never be touched by node operators, but this seems like it would be useful for everyone. I guess I missed commenting on this for eth.
Niche I guess. Just solving a practical issue with minimal code bloat |
|
Can make a config opt at some point. Just need this asap, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12147ba but for BTC
1 second polling is too fast for remote nodes.
This variable affects all btc clone assets.