[0.6.1] backports for release #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not actually tested zcashd v5.4.2 on either testnet or mainnet, only regtest. |
JoeGruffins
approved these changes
Apr 27, 2023
… parsing (decred#2237) getnewaddress and getrawchangeaddress RPCs are deprecated. There is no way to get a transparent address directly. Instead, get a unified address, parse "receivers", and pick out the transparent address. require 5.4.2 and handle RPC deprecations in harness.
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Server orderbook is updated to cache the 100 most recent matches in memory, and they are returned whenever a client syncs the orderbook.
If target tier is <= 0, do not spam about the missing bond wallet. The default bond wallet (42/dcr) might not be configured at all. This is mostly for legacy fee clients.
Override the Read implementing io.Reader and make it do the mirroring. Any read will cause mirroring now automatically.
When an account-based asset is the quote asset in a market, and there is a booked buy order, the quantity to check must be in units of the quote asset (the account-based asset).
Link to the wiki page, and show two provider text boxes from the start.
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
When changing the rpcClient connection config, fall back to full restart in these added cases: - when the rpcClient has a custom connectFunc - when the current deposit address fails to validate with the new client, or when it is not owned by the new wallet. The checks in the second case above were previously only done if the wallet was actively used. Now they are always done, but they are no longer fatal to reconfigure, only live-reconfigure, causing a full reconnect to do the checks again with a new instance of an *rpcClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the fixes from the 0.6.1 milestone, plus:
site/distfiles that are included in the release branches.The backports: