site: set zoom buttons in DepthChart ctor #1799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the error
Uncaught TypeError: can't access property "setExtents", e.zoomOutBttn is undefined
, which happens often on DEX server reconnect events. Probably more so if you have more than one server configured.The best way to reproduce is:
The root of the issue seems to be that the parent constructor was not setting the zoom buttons as intended. And the
requestAnimation
callback that actually was setting them via theresized
reporter is not called until the browser decides to actually draw on the canvas. This is asynchronous, and the steps above try to make it a longer delay.