utility for running core harness tests #1632
Conversation
There was a problem hiding this comment.
Very interesting approach.
I see an error when runnin ltcdcr: rawrequest (sendrawtransaction) error: -3: Amount is not a number or string
I see the balance errors for dcrdoge. doge must use the gamma and delta nodes because it has no accounts so balance tests will always fail when mining blocks. 9fd4054
I also see balance errors for dcreth. Do you think it's because maybe you have included the fee? Eth's estimation or swaps.FeeRate is 200 gwei here. Looking up the actual for the tx I find effectiveGasPrice: 2000000007, which I think is 2 gwei per gas actual.
| @@ -0,0 +1,45 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file needs the chmod +x. Also can it be named run.sh?
| flag.StringVar("e1Node, "quote1node", "beta", "the harness node to connect to for the first client's quote asset. only RPC wallets") | ||
| flag.StringVar(&base2Node, "base2node", "gamma", "the harness node to connect to for the second client's base asset. only RPC wallets") | ||
| flag.StringVar("e2Node, "quote2node", "gamma", "the harness node to connect to for the second client's quote asset. only RPC wallets") | ||
| flag.StringVar(®Asset, "regasset", "gamma", "the harness node to connect to for the second client's quote asset. only RPC wallets") |
There was a problem hiding this comment.
Comment should be about being the register asset?
client/core/simnet_trade.go
Outdated
| client.log("placed order %sing %s at %s (%s)", sellString(client.isSeller), qtyStr, rateStr, ord.ID[:8]) | ||
| client.lastOrder = ord.ID | ||
|
|
||
| client.log.Infof("placed order %sing %s at %s (%s)", sellString(client.isSeller), qtyStr, rateStr, ord.ID[:8]) |
There was a problem hiding this comment.
Must be an old bug but log doesn't look right 2022-05-31 18:24:25.360 [INF] T[1]: placed order selling 20.00000000 dcr at 0.000150000 eth%!(EXTRA string=dcr) (7e764dabd4977779)
client/cmd/simnet-trade-tests/run
Outdated
| list) | ||
| ./simnet-trade-tests --list | ||
| ;; | ||
|
|
||
| help) | ||
| ./simnet-trade-tests --help | ||
| ;; |
There was a problem hiding this comment.
nit: This help should be help for the run file, like maybe the options above, and list isn't so helpful.
Are you using 0.21 in this test? The 0.21 PR isn't merged yet |
|
I'm going to go through and try to resolve some errors. I'm aware of a few. But I'm pretty sure they aren't all mine. |
|
Just for reference, on |
Oh yeah... Using 0.21.2, so that`s probably it. Apologies. |
|
We should probably get that merged too though... Just infuriating that ltc testnet is messed up still (explorers on wrong chain, etc.). I had to make large changes to that PR to to complete deserialization of all the MW tx types though, so it kinda got bigger like the zcash PR. |
|
I think this is ready. If there's any tweaks to be made for Ethereum, I'll do it in #1622. |
They're not all passing yet, but this makes it easier to run different combos for the core simnet harness tests. Still figuring out the failing tests, but the error is always
balance change not in expected range. Could be the same on master.