server: sign and verify hashed messages (sig fix stage 3) #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
force-pushed
the
sig-fix-stage-3
branch
from
8ba07e8 to
4f4f1a2
Compare
This updates the server's AuthManager for the correct signature creation and verification: - When verifying client signatures, only accept properly hashed messages. - When creating signatures, sign the hashed messages. This requires the updated client that recognized both signature types, as is the case since v0.4.2.
chappjc
force-pushed
the
sig-fix-stage-3
branch
from
4f4f1a2 to
0817990
Compare
|
With stage 1 of the fix in v0.4.2 and evidently deployed, and stage 2 merged onto release-v0.4 for an upcoming v0.4.3, this stage of the fix can get on 0.5 assuming there's gonna be time before 0.5 is released. |
buck54321
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stage 3 of the signature message truncation fix plan outlined in #1526.
In these commits, server:
All clients must be running with the stage 2 fix in v0.4.3 before this change can be deployed.
In the next and final stage, the client drops support for truncated message signatures from the server running at this point.