eth/coiner: Save value of one initiation. #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Feb 17, 2022
server/asset/eth/coiner.go
Outdated
Comment on lines
296
to
300
| // If an initiation, return the value of one swap in order to validate | ||
| // during processing. | ||
| if c.initValue != nil { | ||
| return *c.initValue | ||
| } |
There was a problem hiding this comment.
Seems like we just neglected to override the base method with a swapCoin method:
func (c *swapCoin) Value() uint64 {
return c.init.Value
}BTW, good catch!
There was a problem hiding this comment.
Oh... does that work? I was thinking we couldn't override methods in go, I'm such a noob.
There was a problem hiding this comment.
Done. Also added a small log change.
Before:
2022-02-18 11:17:18.366 [INF] CORE: Broadcasted redeem transaction spending 1 contracts for order 5b031052bb914849759ff1ce92b8fd9e75ec0c0e5661a27ae1f261f9ca340c88, paying to {307831633846393038643939463632353232463845304144393530344646634331383765353531346361:1c8f908d99f62522f8e0ad9504ffcc187e5514ca000000003ce5c090} (eth)
After
2022-02-18 13:18:33.608 [INF] CORE: Broadcasted redeem transaction spending 1 contracts for order 161e7f247c527d0ecf69a44a5813ea4fd72254bdd9c10c04529f9f439d2585eb, paying to {0x1c8F908d99F62522F8E0AD9504FFcC187e5514ca:1c8f908d99f62522f8e0ad9504ffcc187e5514ca0000000054285790} (eth)
Save and return the value of a specific initiation rather than the entire transaction value for validation later. This allows coins that share a transaction to be matched separately.
JoeGruffins
force-pushed
the
fixethcoinervalue
branch
from
8fe770a to
f2c6ca2
Compare
chappjc
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1469