client/eth: Sign redeems. #1384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an AccountRedeemer interface that enables signing redeems for account based wallets when they will be a redeemer in a trade.
JoeGruffins
force-pushed
the
signredemption
branch
from
9dadb03 to
2f214c4
Compare
|
I believe that #1314 also signs redeems. Will close this if that gets in first. This only allows for one possible redemption address, which may be a problem if account based wallets ever have more than one address. But for now, it means not much needs to change with the core. |
|
Closing in favor of #1314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preemptively adds the Account Redeemer interface in #1314 This does not attempt to solve the balance reserving problem, but allows signing redemptions so that we can use the eth wallet to redeem trades.