add price rate to browser title #1117
Conversation
| const { book } = mktBook | ||
| // gets first price value from buy or from sell, so we can show it on | ||
| // title. | ||
| const firstKnownValue = book.buys[0] ? book.buys[0] : book.sells[0] |
| @@ -959,6 +959,16 @@ export default class MarketsPage extends BasePage { | |||
| handleBookRoute (note) { | |||
| app.log('book', 'handleBookRoute:', note) | |||
| const mktBook = note.payload | |||
| const { book } = mktBook | |||
There was a problem hiding this comment.
Use const book = mktBook.book for grabbing just one property.
| const { book } = mktBook | ||
| // gets first price value from buy or from sell, so we can show it on | ||
| // title. | ||
| const firstKnownValue = book.buys[0] ? book.buys[0] : book.sells[0] |
There was a problem hiding this comment.
You can update the title after the call to this.handleBook below and just use this.midGap() for the value.
| document.title = (document.title).replace(/\d+([.])?/g, '') | ||
| // more than 6 numbers it gets too big for the title. | ||
| document.title = `${firstKnownValue.rate.toFixed(6)} ${document.title}` |
There was a problem hiding this comment.
I'd like to see the market name. Something like 0.00512 DCR/BTC.
I don't know that we need to save the original title, which said Markets | Decred DEX, but if you do want to append the original text, grab a copy in the MarketPage constructor, this.ogTitle = document.title and just append it rather than using replace.
There was a problem hiding this comment.
I removed the replace and now I am adding the selected assets into the title.
Added a new method for updating it, and now I call it on handleBookRoute, handleUnbookOrderRoute, and handleBookOrderRoute.
This way if we adding or removing new bids, it will update the title based on it.
There was a problem hiding this comment.
I'd like to see the market name. Something like
0.00512 DCR/BTC.
Despite calling it the market name, is giving units to that rate, so it'll need to be BTC/DCR
There was a problem hiding this comment.
Discussion in this thread: #1117 (comment)
Looks like use "DCR-BTC" and don't have units for the number.
| @@ -959,6 +959,16 @@ export default class MarketsPage extends BasePage { | |||
| handleBookRoute (note) { | |||
There was a problem hiding this comment.
Doing this in handleBookRoute will set the price when the book is originally received, but will never update the value. I'm guessing we want the value to update when the book changes.
| const market = this.market | ||
| const [b, q] = [market.baseCfg, market.quoteCfg] | ||
| const firstSymbol = b.symbol.toUpperCase() | ||
| const secondSybol = q.symbol.toUpperCase() |
There was a problem hiding this comment.
spelling: "Sybol"
But might as well change these to baseSymb and quoteSymb while here.
| const secondSybol = q.symbol.toUpperCase() | ||
| if (midGapValue) { | ||
| // more than 6 numbers it gets too big for the title. | ||
| document.title = `${midGapValue.toFixed(5)} ${firstSymbol}/${secondSybol}` |
There was a problem hiding this comment.
This is gonna say something like 0.004 DCR/BTC. The rate is inversed.
There was a problem hiding this comment.
Maybe use a dash instead of a slash. When naming a market, the base symbol goes first by convention.
There was a problem hiding this comment.
I will note that Bittrex bucks this trend
probably because of how confusing it is to have it written the other way.
Still, it's true that the base asset is usually first.
There was a problem hiding this comment.
Somewhere in the Bittrex API docs, I remember reading an acknowledgement of this mistake. The URL and API arguments now use the standard format. Only the display is still wrong.
There was a problem hiding this comment.
OK fair enough. I see the url as https://bittrex.com/Market/Index?MarketName=BTC-DCR, but I don't really strive to emulate Bittrex either way.
This PR is working well for me. However, here's what I see presently:
And here's what I'd like to see:
OR even without a dash, but it's not a big deal:
There was a problem hiding this comment.
I changed it and now I am showing as your last option, without dash.
vctt94
force-pushed
the
add-rate-to-title
branch
from
6c05405 to
b1e8b12
Compare
vctt94
force-pushed
the
add-rate-to-title
branch
from
b1e8b12 to
2f3f735
Compare
closes #1053