client/front-end: Export orders in csv file #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
reviewed
Jun 14, 2021
|
Local time sounds good to me. |
JoeGruffins
approved these changes
Jun 16, 2021
chappjc
requested changes
Jul 5, 2021
chappjc
reviewed
Jul 5, 2021
client/webserver/http.go
Outdated
Comment on lines
293
to
301
| ordReader.OfferString(), // Offer | ||
| ordReader.Type.String(), // Type | ||
| ordReader.SideString(), // Side | ||
| ord.TimeInForce.String(), // Time in Force | ||
| ordReader.StatusString(), // Status | ||
| ordReader.SimpleRateString(), // Rate | ||
| ordReader.FilledPercent(), // Filled | ||
| ordReader.SettledPercent(), // Settled | ||
| ordReader.OfferString(), // Quantity |
There was a problem hiding this comment.
"Offer" and "Quantity" are both set to ordReader.OfferString(). Was "Quantity" supposed to be effectively precision8(ord.Qty)?
There was a problem hiding this comment.
I just copied this from the previous PR, but I've made some changes to the columns now. Let me know what you think.
There was a problem hiding this comment.
Thanks, I don't know what was going on with the previous columns. I like this average rate you added, which makes sense when there are multiple matches that aren't necessarily same rate. Really nice.
chappjc
approved these changes
Jul 9, 2021
|
We'll probably iterate on the csv format going forward, but this is working great and I have no complaints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button on the orders page that allows the user to download their orders in CSV format.
Closes #382