client/assets/eth: in-process geth demo #1010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
commented
Mar 9, 2021
| if key, err = crypto.GenerateKey(); err != nil { | ||
| return nil, err | ||
| } | ||
| stackConf.P2P.PrivateKey = key |
There was a problem hiding this comment.
May or may not have to do this. Needs more testing.
buck54321
commented
Mar 10, 2021
| // ethCfg.Genesis = core.DefaultGenesisBlock() // eth will do this anyway when Genesis == nil is encountered, and the messaging it better that way. | ||
| // ethCfg.SyncMode = downloader.SnapSync // Supposed to be enabled with Berlin on April 14th 2021 | ||
| // ethCfg.SyncMode = downloader.FastSync // The default | ||
| ethCfg.SyncMode = downloader.LightSync |
There was a problem hiding this comment.
Updated here after @JoeGruffins reminded me that fast != light. Much faster now. I'm leaning towards only enabling light mode to start, and then add snap mode option after Berlin.
There was a problem hiding this comment.
I got the impression that snap sync was going to be the default after Berlin, but it could actually work now if other nodes are making snapshots. But that's aside because light is the way to go for client.
|
go-ethereum is comprehensible enough, but I found this reference to be useful too. |
|
Incorporated into #1005. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended as a complement to #1005, hoping to be cannibalized. This snippet demonstrates running geth natively without HTTP RPCs.