Fix bug introduced when addressing reviews, and remove unnecessary m.…

…isCancel check
decred · Apr 11, 2023 · 6240b94 · 6240b94
1 parent e2ddc69
commit 6240b94
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/client/webserver/site/src/js/order.ts b/client/webserver/site/src/js/order.ts
@@ -265,9 +265,7 @@ export default class OrderPage extends BasePage {
    * updated on each update to the match.
    */
   setMutableMatchCardElements (matchCard: HTMLElement, m: Match) {
-    if (m.isCancel) {
-      return
-    }
+    if (m.isCancel) return
 
     const tmpl = Doc.parseTemplate(matchCard)
     tmpl.status.textContent = OrderUtil.matchStatusString(m)
@@ -313,13 +311,13 @@ export default class OrderPage extends BasePage {
       }
       Doc.hide(tmpl.refundCoin)
       Doc.show(tmpl.refundPending)
-      return
+    } else {
+      tmpl.refundCoin.textContent = formatCoinID(m.refund.stringID)
+      tmpl.refundCoin.dataset.explorerCoin = m.refund.stringID
+      setCoinHref(m.refund.assetID, tmpl.refundCoin)
+      Doc.show(tmpl.refundCoin)
+      Doc.hide(tmpl.refundPending)
     }
-    tmpl.refundCoin.textContent = formatCoinID(m.refund.stringID)
-    tmpl.refundCoin.dataset.explorerCoin = m.refund.stringID
-    setCoinHref(m.refund.assetID, tmpl.refundCoin)
-    Doc.show(tmpl.refundCoin)
-    Doc.hide(tmpl.refundPending)
 
     if (m.status === OrderUtil.MakerSwapCast && !m.revoked && !m.refund) {
       const c = makerSwapCoin(m)
@@ -341,7 +339,6 @@ export default class OrderPage extends BasePage {
       Doc.show(tmpl.takerRedeemMsg)
     } else {
       Doc.hide(tmpl.makerSwapMsg, tmpl.takerSwapMsg, tmpl.makerRedeemMsg, tmpl.takerRedeemMsg)
-      if (m.isCancel) return
     }
 
     if (!m.revoked) {