Add Reproducible Builds page #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
requested changes
Sep 30, 2020
| different conditions, and always yield the same result when given the same | ||
| input. | ||
| The output of a truly deterministic build will be identical down to every | ||
| individual bit, such that equality can be measured using MD5/SHA1 hashes. |
There was a problem hiding this comment.
these are bad examples of a cryptographic hash in 2020. let's say SHA256 since that is what the manifest currently commits to.
| - `-trimpath` is used to remove all file system paths from compiled executables | ||
| - The `buildid` added by the linker is hard-coded to empty string | ||
| - Local `GOFLAGS` are overwritten to empty string | ||
| - The `netgo` build tag is used to ensure statically linked binaries |
There was a problem hiding this comment.
this and disabling cgo does not strictly result in static binaries for all platforms and it would be better to remove that. Currently, the Darwin executables use dynamic linking, and this should be the case for OpenBSD as well shortly.
What is true is that these settings result in the same build as a cross compile for the target from a different target, even when locally building from the same target.
|
Thanks jrick. A new commit addresses both of your comments |
jrick
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
Requesting review from @jrick. Is there anything else I have missed in the
decred/releasesource which is worth mentioning?