blockchain: Use hash values in structs. #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_concrete_hash_in_structs
branch
2 times, most recently
from
7215de9 to
bcea2b7
Compare
dnldd
approved these changes
Jan 29, 2018
alexlyp
approved these changes
Jan 29, 2018
davecgh
force-pushed
the
blockchain_concrete_hash_in_structs
branch
from
bcea2b7 to
73a5e0f
Compare
This modifies the BestState struct in the blockchain package to store hashes directly instead of pointers to them and updates callers to deal with the API change in the exported BestState struct. In general, the preferred approach for hashes moving forward is to store hash values in complex data structures, particularly those that will be used for cache entries, and accept pointers to hashes in arguments to functions. Some of the reasoning behind making this change is: - It is generally preferred to avoid storing pointers to data in cache objects since doing so can easily lead to storing interior pointers into other structs that then can't be GC'd - Keeping the hash values directly in the structs provides better cache locality
davecgh
force-pushed
the
blockchain_concrete_hash_in_structs
branch
from
73a5e0f to
20a8ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #990
This modifies the
BestStatestruct in theblockchainpackage to store hashes directly instead of pointers to them and updates callers to deal with the API change in the exportedBestStatestruct.In general, the preferred approach for hashes moving forward is to store hash values in complex data structures, particularly those that will be used for cache entries, and accept pointers to hashes in arguments to functions.
Some of the reasoning behind making this change is: