checkdevpremine: Small improvements and fixes #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusrichter
changed the title
davecgh
requested changes
Jan 9, 2018
There was a problem hiding this comment.
Thanks for the PR. Please name the commit(s) according to the Model Git Commit Message section of the Code Contribution Guidelines.
Also, please explicitly call out that intended changes in the PR description.
The option --skipverify has never been implemented, therefore it is better to remove it altogether.
Similar to all other utilities in github.com/decred/dcrd/cmd/... The main Go file for "utility" is usually named utility.go and not main.go.
The comment didn't reflect the code (probably a copy and paste error).
markusrichter
force-pushed
the
checkdevpremine
branch
from
82cd339 to
e3abbcd
Compare
|
Thanks for the feedback and pointer @davecgh. I made the requested changes, I hope in the correct way. Otherwise, please let me know. |
markusrichter
changed the title
davecgh
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some small improvements to the
checkdevpreminecommand: It removes the unimplemented--skipverifyoption, implements the unimplemented--notlsoption, and fixes a comment which didn't fit the code it was documenting.It also renames the file
main.gotocheckdevpremine.goto make the naming more consistent with other utilities.