chaincfg: Introduce new type DNSSeed #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older nodes previously added the IP and port information to the address manager which proved to be unreliable as an inbound connection from a peer didn't necessarily mean the peer itself accepted inbound connections. This also fixes a bug where the peer package was incorrectly sending the peer's services as its own.
DNSSeed defines a DNS Seed with a hostname and whether it supports filtering by service flag bits.
|
@dnldd did you run this? |
|
@dajohi yes, run it on testnet. dcrd synced without errors. Did I miss something? |
|
sorry, no. just wanted to make sure you ran it with peers.json removed. |
davecgh
requested changes
Jan 17, 2018
chaincfg/params.go
Outdated
| return d.Host | ||
| } | ||
|
|
||
| // Register registers the network parameters for a Bitcoin network. This may |
There was a problem hiding this comment.
Looks like you accidentally reverted the Decred to Bitcoin. s/Bitcoin/Decred/
DNSSeed defines a DNS Seed with a hostname and whether it supports filtering by service flag bits.
dnldd
force-pushed
the
merge_seedservice
branch
from
f685f08 to
7f7894c
Compare
davecgh
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following upstream commits:
DNSSeed defines a DNS Seed with a hostname and whether it supports
filtering by service flag bits.