blockchain: Fix return amts test for Go 1.23+. #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
jrick
approved these changes
Aug 20, 2024
This updates the test for ticket return calculation amounts to work properly with Go 1.23+. Specifically, it updates the default ticket commitment script that is used when creating the mock minimal ouputs that the tests then modify to be an actual commitment script. Note that this is solely a test issue. It appears that an invalid mock ticket commitment script was specified when the test was created, but since the tests only deal with the return amounts which are explicitly modified in the mock script to the values the test data requires, it did not previously matter. However, the code that updates the mock script for the tests inadvertently relied on undocumented behavior in hex.DecodeString returning a slice with a larger capacity which allowed the slice to be extended when setting the appropriate amounts. However, that is no longer the case as of Go 1.23+ which uncovered the otherwise invalid script.
davecgh
force-pushed
the
blockchain_fix_ticket_return_amts_test_go_1_23
branch
from
2bd25aa
to
d505edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test for ticket return calculation amounts to work properly with Go 1.23+.
Specifically, it updates the default ticket commitment script that is used when creating the mock minimal ouputs that the tests then modify to be an actual commitment script. Note that this is solely a test issue.
It appears that an invalid mock ticket commitment script was specified when the test was created, but since the tests only deal with the return amounts which are explicitly modified in the mock script to the values the test data requires, it did not previously matter.
However, the code that updates the mock script for the tests inadvertently relied on undocumented behavior in
hex.DecodeStringreturning a slice with a larger capacity which allowed the slice to be extended when setting the appropriate amounts. However, that is no longer the case as of Go 1.23+ which uncovered the otherwise invalid script.