multi: Wrap errors for better errors.Is/As support. #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
suggested changes
Aug 25, 2023
davecgh
force-pushed
the
multi_error_wrap
branch
from
2057b07 to
79be34a
Compare
This updates all remaining cases of unwrapped errors in fmt.Errorf calls to wrap the underlying errors with the %w format verb to ensure they work nicely with errors.Is and errors.As.
davecgh
force-pushed
the
multi_error_wrap
branch
from
79be34a to
318d81b
Compare
jholdstock
approved these changes
Aug 26, 2023
dajohi
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all remaining cases of unwrapped errors in
fmt.Errorfcalls to wrap the underlying errors with the%wformat verb to ensure they work nicely witherrors.Isanderrors.As.