apbf: Switch to fast reduce method. #2584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2579.
This modifies the modular reduction step to make use of the same fast reduce mechanism used in the
gcs
filters. As can be seen in the following benchmark results, it more than doubles the performance of the primary filter operations.In order to experimentally validate the mapping adheres to the theoretical results and doesn't have any adverse effects on the false positive rates, the same validation methodology described in
README.md
was conducted again and saidREADME
is updated accordingly. Everything is well within the margin of error as expected.Finally, the
README
is also updated with the new benchmark results and the required go version is bumped in the go.mod due to the addition of the math/bits import.