Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unused and undesired
FromPBytes
andFromNPBytes
functions and associated tests from thegcs
module in preparation for upcoming changes aimed to support new version filters for use in header commitments.Since these changes, and several planned upcoming ones, constitute breaking pubic API changes, this bumps the major version of the
gcs
module, adds a replacement forgcs/v2
to themain
module and updates all other modules to make use of it.It also bumps the
rpcclient
module tov5
since it makes use of thegcs.Filter
type in its API, adds a replacement forrpcclient/v5
to themain
module and updates all other modules to make use of it.Note that this also marks the start of a new approach towards handling module versioning between release cycles to reduce the maintenance burden.
The new approach is as follows.
Whenever a new breaking change to a module's API is introduced, the following will happen:
Finally, once the repo is frozen for software release, all modules will be tagged in dependency order to stabilize them and all module replacements will be removed in order to ensure releases are only using
fully tagged and released code.