dcrjson: Introduce v2 module without wallet types. #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
dcrjson_introduce_v2_without_wallet_types
branch
from
dace323 to
f7c1f82
Compare
jrick
reviewed
Feb 14, 2019
This updates README.md to call out it implements decred JSON-RPC API and correct a style nit.
This moves the test for estimatefee to the chainsvrcmds_test.go file to match the fact it's defined in chainsvrcmd.go.
This moves the command definitions and associated types for the createrawsstx and createrawssrtx commands to the chainsvrcmds.go file since they are served by the chain RPC server.
This moves the result definition for the getbestblock command to the chainsvrresults.go file since it is served by the chain RPC server.
This moves the definition and associated code for the winningtickets notification to the chainsvrwsntfns.go file since it is served by the chain RPC websocket server. It also moves the associated test to the chainsvrwsntfns_test.go file accordingly.
This moves the definition and associated code for the spentandmissedtickets notification to the chainsvrwsntfns.go file since it is served by the chain RPC websocket server. It also moves the associated test to the chainsvrwsntfns_test.go file accordingly.
This moves the definition and associated code for the stakedifficulty notification to the chainsvrwsntfns.go file since it is served by the chain RPC websocket server.
This moves the definition and associated code for the newtickets notification to the chainsvrwsntfns.go file since it is served by the chain RPC websocket server. It also moves the associated test to the chainsvrwsntfns_test.go file
This removes all wallet-specific type definitions and tests from the dcrjson module since they are being moved into their own module that lives in the dcrwallet repository. Since this constitutes a major break to the API, it also bumps the module version to version 2.
This updates the docs/README.md file, module hierarchy graphviz, and module hierarchy diagram to reflect the new module version.
davecgh
force-pushed
the
dcrjson_introduce_v2_without_wallet_types
branch
from
0a43747 to
9265b40
Compare
jrick
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all wallet-specific type definitions and tests from the
dcrjsonmodule since they are being moved into their own module that lives in thedcrwalletrepository.In order to accomplish this, a series of individual commits have been used been to make the review process easier. Each commits message more thoroughly describes its purpose, but primarily they all consist of either docs updates or moving commands, notifications, and results that are served by the chain server into the appropriate files since they were improperly categorized in the wallet files which is incorrect because wallet consumes them as opposed to serving them.
Finally, since this constitutes a major break to the API, it also bumps the module version to version 2.
It should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the v1 module (if not using the overrides in the root module).