Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: remove MsgAlert #1161

Merged
merged 1 commit into from
Mar 29, 2018
Merged

multi: remove MsgAlert #1161

merged 1 commit into from
Mar 29, 2018

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Mar 28, 2018

It is currently unused and does not fit into decentralization.

Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a protocol change without a protocol version bump. Even though nothing uses it, the protocol version in wire and the associated one in peer, should be bumped.

@dajohi
Copy link
Member Author

dajohi commented Mar 29, 2018

updated

It is currently unused and does not fit into decentralization.
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this offline and we're not going to bump the protocol version because nothing ever used this message and if it had ever been used, it couldn't be removed anyways since the newer versions would still need to be able to negotiate down to older protocol versions where it was supported.

@davecgh davecgh merged commit 8c0d288 into decred:master Mar 29, 2018
@dajohi dajohi deleted the nomsgalert branch February 28, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants