chaingen: Add revocation generation infrastructure. #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
chaingen_add_revocation_infastructure
branch
2 times, most recently
from
d33d866 to
ed1d03f
Compare
dnldd
approved these changes
Mar 5, 2018
alexlyp
approved these changes
Mar 5, 2018
marcopeereboom
approved these changes
Mar 5, 2018
davecgh
force-pushed
the
chaingen_add_revocation_infastructure
branch
from
ed1d03f to
71332c6
Compare
This adds infrastructure to track missed votes and automatically generate revocations for them along with a new assertion helper named AssertTipNumRevocations which, as it name suggests, allows the caller to assert the header commits to the specified number of revocations. This will be useful for porting the rest of the block validation tests to the fullblocktests framework.
davecgh
force-pushed
the
chaingen_add_revocation_infastructure
branch
from
71332c6 to
a0bdb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds infrastructure to track missed votes and automatically generate revocations for them along with a new assertion helper named
AssertTipNumRevocationswhich, as it name suggests, allows the caller toassert the header commits to the specified number of revocations.
This will be useful for porting the rest of the block validation tests to the
fullblocktestsframework.