Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connmgr: Use same Dial func signature as net.Dial #1113

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

jrick
Copy link
Member

@jrick jrick commented Mar 2, 2018

No description provided.

@davecgh
Copy link
Member

davecgh commented Mar 4, 2018

We'll need to talk to the folks who made the upstream change before I approve this. I believe it was changed specifically to allow a use case needed by the LN devs, so I don't want to undo it without having a conversation first.

@davecgh
Copy link
Member

davecgh commented Mar 5, 2018

After digging into this some more, the intention of the upstream change was to allow the internal structures to use a net.Addr for GetNewAddress and Connect. The Dial function itself doesn't need to take the net.Addr directly since the caller can always just do .Diala(ddr.Network(), addr.String()) to achieve the same effect.

@davecgh davecgh merged commit eb9f01f into decred:master Mar 5, 2018
@jrick jrick deleted the dialargs branch March 5, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants