blockchain: Use chaingen for forced reorg tests. #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces and improves the tests for the ForceHeadReorganization function with new tests based on the dynamic chaingen infrastructure versus uses static test data that gets out of date as data structures change and is much more difficult to update. It also removes the now unused static reorgto180.bz2 test data.
davecgh
force-pushed
the
blockchain_dynamic_force_reorg
branch
from
24a1351 to
1492e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1072.(now merged)This replaces and improves the tests for the
ForceHeadReorganizationfunction with new tests based on the dynamicchaingeninfrastructure versus uses static test data that gets out of date as data structures change and is much more difficult to update.It also removes the now unused static
reorgto180.bz2test data.