blockchain: Calculate the lottery IV on demand. #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_calc_lottery_iv
branch
3 times, most recently
from
dde301f to
b65b46d
Compare
jrick
approved these changes
Feb 21, 2018
davecgh
force-pushed
the
blockchain_calc_lottery_iv
branch
from
b65b46d to
0523885
Compare
This provides a function to calculate the lottery initialization vector for a node on demand versus calculating it at node creation time and storing the result. This is being done because it saves an additional 32 bytes in the block node structure and the ultimate goal is to move towards having all block nodes in memory to greatly simplify and optimize the code. Since there will be a lot of nodes in memory, these extra bytes can add up to significant savings.
davecgh
force-pushed
the
blockchain_calc_lottery_iv
branch
from
0523885 to
17f957f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a function to calculate the lottery initialization vector for a node on demand versus calculating it at node creation time and storing the result.
This is being done because it saves an additional 32 bytes in the block node structure and the ultimate goal is to move towards having all block nodes in memory to greatly simplify and optimize the code. Since there will be a lot of nodes in memory, these extra bytes can add up to significant savings.