blockchain: Improve readability of parent approval. #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces two new functions to the blockchain package named headerApprovesParent and voteBitsApproveParent and updates all call sites in the package in order to improve the readability and more clearly describe the intention of the code.
davecgh
force-pushed
the
blockchain_approve_parent
branch
from
4d481a3 to
dd5c048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new functions to the
blockchainpackage namedheaderApprovesParentandvoteBitsApproveParentand updates all call sites in the package in order to improve the readability and more clearly describe the intention of the code.