blockchain: Validate pool size in header context. #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Feb 2, 2018
davecgh
force-pushed
the
blockchain_validate_poolsize_header_context
branch
2 times, most recently
from
35701d1 to
51a61e8
Compare
This moves the test for validating the pool size specified by the header matches the calculated size into the checkBlockHeaderContext function where it more naturally belongs since it is only dependent on the header and its contextual position within the chain.
davecgh
force-pushed
the
blockchain_validate_poolsize_header_context
branch
from
51a61e8 to
c5a7115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #1017.
This moves the test for validating the pool size specified by the header matches the calculated size into the
checkBlockHeaderContextfunction where it more naturally belongs since it is only dependent on the header and its contextual position within the chain.