blockchain: Block sanity cleanup and consistency. #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Feb 2, 2018
This cleans up the checkBlockSanity and make it more consistent with the rest of the code base. The following is an overview of the changes: - Use the local variable throughout - Check the header values against the expected value instead of the reverse - Make the errors more consistent and verbose in some cases - Use an int64 for the type so consensus doesn't different between computer architecture - Correct and add some comments
davecgh
force-pushed
the
blockchain_checkblocksanity_cleanup
branch
from
9d9826d to
7c7e6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PRs #1008, #1009, #1010, and #1011.
This cleans up the
checkBlockSanityand make it more consistent with the rest of the code base.The following is an overview of the changes: