blockchain: No votes/revocations in header sanity. #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the validation that the block does not contain any votes or revocations before stake enabled height and stake validation height to make use of the values committed to by the header and thus moves the test into checkBlockHeaderSanity accordingly. It also combines the two checks to only check before stake validation height since that always comes after stake enabled height and adds an assertion to ensure that optimization assumption holds. This is acceptable since the code also validates the header commitments for the number of votes and revocations later and therefore implies correctness.
davecgh
force-pushed
the
blockchain_validate_novotes_revocations_header_sanity
branch
from
92cdf09 to
370dfa1
Compare
jrick
approved these changes
Feb 2, 2018
davecgh
deleted the
blockchain_validate_novotes_revocations_header_sanity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the validation that the block does not contain any votes or revocations before stake enabled height and stake validation height to make use of the values committed to by the header and thus moves the test into
checkBlockHeaderSanityaccordingly.It also combines the two checks to only check before stake validation height since that always comes after stake enabled height and adds an assertion to ensure that optimization assumption holds.
This is acceptable since the code also validates the header commitments for the number of votes and revocations later and therefore implies correctness.